Remove copy constructibility from -----------------------------------
Key: THRIFT-1317 URL: https://issues.apache.org/jira/browse/THRIFT-1317 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor >From 2af8bd64d2ec3a0792ab247ab7ffbc75b00ce302 Mon Sep 17 00:00:00 2001 From: Jordan DeLong <jdel...@fb.com> Date: Tue, 20 Apr 2010 19:21:45 +0000 Subject: [PATCH 28/33] Remove copy constructibility from thrift::concurrency::Guard Summary: Copy constructing this class currently will cause a mutex to get unlocked twice. It looks like this was an unintended consequence of changing the mutex_ member from a reference to a pointer. Test Plan: Compiled (random project using this). But anything this change breaks probably has a copy construction bug in their guard usage. Revert Plan: OK --- lib/cpp/src/concurrency/Mutex.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira