[ 
https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113476#comment-13113476
 ] 

Jake Farrell commented on THRIFT-1357:
--------------------------------------

The build infra is a stock ubuntu with only the required packages to help keep 
the system stable and in a known 'good' state. If the jsx lib depends on a 
specific version of erl then we should add that check into configure and if not 
met dont allow the erl client lib to be built (similar to ruby and the spec vs 
rspec versioning issue). If you are good with this path then I can throw 
together a patch to detect the erlang version on initial configure which should 
resolve this

> Erlang Dependency breaks build
> ------------------------------
>
>                 Key: THRIFT-1357
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1357
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>         Environment: Apache build Infrastructure based on Ubuntu lucid
> {noformat}
> ii  erlang-base                                     1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto                                   1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP cryprographic modules
> ii  erlang-dev                                      1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP development libraries and headers
> ii  erlang-eunit                                    1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP module for unit testing
> ii  erlang-syntax-tools                             1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP modules for handling abstract Erl
> ii  erlang-base                                     1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP virtual machine and base applicat
> ii  erlang-crypto                                   1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP cryprographic modules
> ii  erlang-dev                                      1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP development libraries and headers
> ii  erlang-eunit                                    1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP module for unit testing
> ii  erlang-syntax-tools                             1:13.b.3-dfsg-2ubuntu2.1  
>                       Erlang/OTP modules for handling abstract Erl
> {noformat}
>            Reporter: Roger Meier
>
> THRIFT-1227 introduced JSON for erlang,
> however the Ubuntu build infrastructur does not support this...
> {noformat}
> ./rebar get-deps
> ==> erl (get-deps)
> Pulling jsx from {git,"git://github.com/talentdeficit/jsx.git",{tag,"v0.9.0"}}
> Initialized empty Git repository in 
> /home/jenkins/jenkins-slave/workspace/Thrift/thrift/lib/erl/deps/jsx/.git/
> ==> nicefloats (get-deps)
> ==> jsx (get-deps)
> ./rebar compile
> ==> nicefloats (compile)
> Compiled src/nicefloats.erl
> ==> jsx (compile)
> ./include/jsx_common.hrl:34: type jsx_opt() undefined
> ./include/jsx_common.hrl:66: type jsx_parser_result() undefined
> ./include/jsx_common.hrl:82: type eep0018_array() undefined
> ./include/jsx_common.hrl:82: type eep0018_object() undefined
> ./include/jsx_common.hrl:84: type eep0018_term() undefined
> ./include/jsx_common.hrl:85: type eep0018_key() undefined
> ./include/jsx_common.hrl:85: type eep0018_term() undefined
> ./include/jsx_common.hrl:91: type eep0018_string() undefined
> ./include/jsx_common.hrl:92: type eep0018_number() undefined
> ./include/jsx_common.hrl:100: type encoder_opt() undefined
> ./include/jsx_common.hrl:109: type decoder_opt() undefined
> ./include/jsx_common.hrl:117: type verify_opt() undefined
> ./include/jsx_common.hrl:123: type format_opt() undefined
> make[3]: *** [all] Error 1
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to