[
https://issues.apache.org/jira/browse/THRIFT-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119127#comment-13119127
]
Kenjiro Fukumitsu edited comment on THRIFT-1366 at 10/3/11 2:48 AM:
--------------------------------------------------------------------
I think python-style command line option is good.
But I don't think merging our t_XXX_generator.cc is not a good idea,
because generated code is so different and it seems unnecesary to process for
both versions of Delphi in one t_XXX_generator.cc.
(Plus,since my generator passed unit test and I would like rmeove the
possibilities to include unneccesary degrade.)
It would be nice if generator factory have the function to understand
option(the word after colon in "delphi:XXX").Otherwise we need the wrapper
which redirects to actual implementation dependind on options.
was (Author: kenjiro):
I think python-style command line option is good.
But I don't think merging our t_XXX_generator.cc is not a good idea,
because generated code is so different and it seems unnecesary to process for
both versions of Delphi in one t_XXX_generator.cc.
(Plus,since my generator passed unit test and I would like rmeove the
possibilities to include unneccesary degrade.)
It would be nice if generator factory have the function to understand
option(the word after colon in "delphi:XXX").
> Delphi generator, lirbrary and unit test.
> -----------------------------------------
>
> Key: THRIFT-1366
> URL: https://issues.apache.org/jira/browse/THRIFT-1366
> Project: Thrift
> Issue Type: New Feature
> Reporter: Kenjiro Fukumitsu
> Attachments: THRIFT-1366_delphi_generator_lib_test.patch
>
>
> I wrote Delphi generator, lirbrary and unit test.
> It works with Delphi XE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
