[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119542#comment-13119542 ]
Roger Meier commented on THRIFT-1351: ------------------------------------- Hi Hans, please provide a patch and grant License to ASF? see: http://wiki.apache.org/thrift/HowToContribute Thanks! -roger > Compiler does not care about binary strings > ------------------------------------------- > > Key: THRIFT-1351 > URL: https://issues.apache.org/jira/browse/THRIFT-1351 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler > Affects Versions: 0.7 > Reporter: Hans Duedal > Labels: compiler, node, nodejs > Fix For: 0.8 > > Original Estimate: 5m > Remaining Estimate: 5m > > The node.js lib has support for binary strings, but the compiler does not > check for it. > It's quite easily fixed: > https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee > With the fix node.js server implementations can operate on binary arguments. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira