[ https://issues.apache.org/jira/browse/THRIFT-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131268#comment-13131268 ]
Kenjiro Fukumitsu commented on THRIFT-1396: ------------------------------------------- I will upload the patch to remove boost dependancy. > Just checking for HAVE_BOOST will not solve this since its based on a > specific boost version. If the guid is not providing and significant > improvement then i would be in favor of removing it for now I mean if HAVE_BOOST is defined, we can include boost/version.hpp to know the version like following lines. // To enable boost version check for guid generation, uncomment the line below. //#define CHECK_BOOST_VERSION #ifdef CHECK_BOOST_VERSION #ifdef HAVE_CONFIG_H #include <config.h> #ifdef HAVE_BOOST #include <boost/version.hpp> #if BOOST_VERSION >= 104200 #define GEN_GUID_ENABLED #include <boost/uuid/uuid.hpp> #include <boost/uuid/uuid_generators.hpp> #include <boost/uuid/uuid_io.hpp> #endif //BOOST_VERSION >= 104200 #endif // HAVE_BOOST #endif // HAVE_CONFIG #endif // GEN_GUID > Dephi generator has dependacy on boost 1.42 later. > -------------------------------------------------- > > Key: THRIFT-1396 > URL: https://issues.apache.org/jira/browse/THRIFT-1396 > Project: Thrift > Issue Type: Improvement > Affects Versions: 0.8 > Reporter: Kenjiro Fukumitsu > Assignee: Jake Farrell > > Build fails if boost/uuid does not exist. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira