[
https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136990#comment-13136990
]
Aurélien Revol commented on THRIFT-1031:
----------------------------------------
@James: Thanks for the suggestion! If there is no practical way to somehow
reuse the existing Makefiles in MS Visual Studio (I suppose nmake is too badly
broken for that?), the premake approach does look reasonable. Still I'm curious
too about what makes you feel that premake is better than CMake?
@Roger: here are some stats about both premake and CMake if that can be of any
help:
http://www.ohloh.net/p/premake
http://www.ohloh.net/p/cmake
Those make me agree with your concern that premake looks riskier to engage with.
The issue I see with CMake, contrarily to premake, is that its documentation
does not clearly state that MSVC 2010 is actually supported. So I guess the
only way to find out would be to try.
Aurelien
> Patch to compile Thrift for vc++ 9.0 and 10.0
> ---------------------------------------------
>
> Key: THRIFT-1031
> URL: https://issues.apache.org/jira/browse/THRIFT-1031
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Environment: Windows XP 32bit, vc++ 9.0, 10.0
> Reporter: James Dickson
> Assignee: Roger Meier
> Priority: Trivial
> Fix For: 0.8
>
> Attachments: PosixThreadFactory.patch, thrift_msvc.patch,
> thrift_msvc_v0_1.patch, thrift_msvc_v0_2.patch, thrift_msvc_v0_3.patch,
> thrift_msvc_v0_4.patch, thrift_msvc_v0_5.patch, thrift_msvc_v0_6.patch,
> thrift_msvc_v0_7.patch
>
>
> At our company we need clients running on Windows being able to connect to
> our linux servers running hypertable. The attached patch enables the parts
> needed by Hypertable to be compiled on Windows using either the VC++ 9.0 or
> 10.0 compilers.
> Having read previous posts about ports using boost::asio we found these to be
> too intrusive for our needs. This version uses pthreads_win32 and winsock2
> and is as designed to be as un-intrusive as is possible to the original unix
> code base. It is mostly #defines between unix sockets and winsock2 sockets.
> We also tried to follow the folder structuring of the C# runtime that has
> visual studio solutions to be consistent.
> More details are in the README as not all the functionality of the original
> unix code base is available to windows users. We will add the missing
> functionality, we just wanted to share what we had as for a Windows based
> client for us it is sufficient.
> The patch is based on the latest revision in SVN, we would love feedback and
> any code reviews. If there is any possibility of this being added to the main
> trunk then that would be much appreciated, however we don't expect that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
