[ 
https://issues.apache.org/jira/browse/THRIFT-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153446#comment-13153446
 ] 

Mike Riley commented on THRIFT-1090:
------------------------------------

I think really instead of documentation the Java generator shouldn't be 
clobbering constants defined in separate thrift files.

To the best of my understanding, most users are defining all constants in one 
file for each namespace so this doesn't become an issue.  Documented or not, it 
still doesn't seem like a reasonable constraint for how you're allowed to 
define constants.

I have this patched in my local copy to just generate a separate .java file 
containing constants for each program (.thrift file) that contains them.  This 
might not be an ideal solution for everyone but it's how I worked around it.

Any other suggestions?
                
> Document the generation of a file called "Constants.java"
> ---------------------------------------------------------
>
>                 Key: THRIFT-1090
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1090
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Documentation, Java - Library, Website
>            Reporter: Lars Francke
>            Priority: Minor
>
> A file called "Constants.java" is generated per thrift file that includes any 
> constants. This should be documented somewhere because if you have multiple 
> thrift files sharing the same namespace there will be clashes.
> (there is no "documentation" component so feel free to adjust those)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to