[ 
https://issues.apache.org/jira/browse/THRIFT-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159940#comment-13159940
 ] 

Anatoly Kanivetsky commented on THRIFT-1326:
--------------------------------------------

>> C99 inttypes.h includes stdint.h, so there's no need to include stdint.h 
>> separately. Though on some systems with inttypes.h there is no stdint.h, 
>> making it impossible to have a #include stdint.h in Thrift.h

It sounds like a reasonable concern to avoid including stdint.h directly. But 
why should we avoid including inttypes.h on all platforms? There are some 
systems, on which including inttypes.h will break any build, since they 
includes stdint.h, which is absent on this systems? Or missed something?
                
> on some platforms, #include <stdint.h> is necessary to be included in Thrift.h
> ------------------------------------------------------------------------------
>
>                 Key: THRIFT-1326
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1326
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.7
>         Environment: Mac OSX 10.6.8 / x86_64 / GCC 4.6.1 for building thrift 
> and server code generated by thrift
>            Reporter: Philippe STRAUSS
>            Assignee: Jake Farrell
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> building server code generated by thrift, I needed to add #include <stdint.h> 
> in main Thrift.h to prevent an "error: uint32_t does not define a type" 
> error. Maybe it does not show on linux, or with earlier GCC.
> Maybe there is a better place than the main Thrift.h for thins #include 
> <stdint.h>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to