Don't change types of arguments when serializing with thrift php extension
---------------------------------------------------------------------------
Key: THRIFT-1453
URL: https://issues.apache.org/jira/browse/THRIFT-1453
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Reporter: Dave Watson
Priority: Minor
Attachments:
0004-Don-t-change-types-of-arguments-when-serializing-wit.patch
>From c630a1a3d7485678176c53e365d20b38db17f8bd Mon Sep 17 00:00:00 2001
From: Dan 'Sabretooth' Weatherford <dweatherf...@fb.com>
Date: Fri, 25 Jun 2010 03:39:58 +0000
Subject: [PATCH 4/5] Don't change types of arguments when serializing with
thrift php extension
Summary:
If the PHP variable type is not compatible with the desired serialization type,
we'll copy the variable before doing the conversion. If it is compatible, this
just adds a little refcount fiddling, so it shouldn't slow down much.
Test Plan:
Passed a bool, int, and double to functions expecting strings, and verified
that the types were unchanged afterwards. (Previously, they'd all end up as
strings.)
DiffCamp Revision: 126908
Reviewed By: dreiss
CC: dreiss, kholst, thrift-team@lists
Revert Plan:
OK
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
