[
https://issues.apache.org/jira/browse/THRIFT-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169880#comment-13169880
]
Hudson commented on THRIFT-1461:
--------------------------------
Integrated in Thrift #368 (See [https://builds.apache.org/job/Thrift/368/])
THRIFT-1461 Recent TNonblockingServer changes broke
--enable-boostthreads=yes, Windows
Patch: Alexandre Parenteau
roger : http://svn.apache.org/viewvc/?view=rev&rev=1214547
Files :
* /thrift/trunk/compiler/cpp/compiler.vcxproj
* /thrift/trunk/compiler/cpp/src/thrifty.yy
* /thrift/trunk/configure.ac
* /thrift/trunk/lib/cpp/src/concurrency/PlatformThreadFactory.h
* /thrift/trunk/lib/cpp/src/concurrency/PosixThreadFactory.cpp
* /thrift/trunk/lib/cpp/src/concurrency/Thread.h
* /thrift/trunk/lib/cpp/src/concurrency/ThreadManager.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
* /thrift/trunk/lib/cpp/src/server/TThreadPoolServer.cpp
* /thrift/trunk/lib/cpp/src/windows/config.h
* /thrift/trunk/lib/cpp/test/Makefile.am
> Recent TNonblockingServer changes broke --enable-boostthreads=yes, Windows
> --------------------------------------------------------------------------
>
> Key: THRIFT-1461
> URL: https://issues.apache.org/jira/browse/THRIFT-1461
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Linux, Windows
> Reporter: alexandre parenteau
> Assignee: alexandre parenteau
> Labels: patch
> Fix For: 0.9
>
> Attachments: THRIFT-1461-2.txt, THRIFT_1461.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Following the (nice) improvements for TNonblockingServer in THRIFT-1442, this
> patch restores both --enable-boostthreads=yes, and the Windows build.
> Included in this patch:
> - Add more HAVE_CONFIG_H includes
> - Replace PosixThreadFactory by PlatformThreadFactory where appropriate
> - Abstract away pthread vs boost::thread inside Thread.h, adding new methods
> is_current/get_current
> - Renamed INVALID_SOCKET, caused compilation problems on Windows (already
> defined in WinSock2.h)
> - Restore back more portable evutil_socketpair (in place of pipe, for Windows)
> - Add evutil_make_socket_nonblocking (as of THRIFT-1442)
> Also included (minor):
> - Add x64 target to VisualC++ compiler
> - Fix minor glitch in bison/compiler for VisualC++
> - Remove more VisualC++ warnings
> This was tested on Ubuntu 10.10, Boost 1.44, Libevent 2.0.16, Visual C++ 10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
