[ 
https://issues.apache.org/jira/browse/THRIFT-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176346#comment-13176346
 ] 

Hudson commented on THRIFT-317:
-------------------------------

Integrated in Thrift #373 (See [https://builds.apache.org/job/Thrift/373/])
    THRIFT-317. java: Issues with Java struct validation

Nested structs will now be validated before serialization starts.

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1225035
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc
* /thrift/trunk/lib/java/test/org/apache/thrift/TestStruct.java
* /thrift/trunk/test/ThriftTest.thrift

                
> Issues with Java struct validation
> ----------------------------------
>
>                 Key: THRIFT-317
>                 URL: https://issues.apache.org/jira/browse/THRIFT-317
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler, Java - Library
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.9
>
>         Attachments: thrift-317.patch
>
>
> The generated validate() methods don't call validate() on their child structs 
> directly. Instead, they wait until the child structs' write() method is 
> called. This could lead to structs being partially written to the wire before 
> encountering an invalid substruct. Additionally, users calling validate() 
> directly would not get the expected behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to