[
https://issues.apache.org/jira/browse/THRIFT-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178863#comment-13178863
]
Hudson commented on THRIFT-1479:
--------------------------------
Integrated in Thrift #374 (See [https://builds.apache.org/job/Thrift/374/])
THRIFT-1479. php: Compiled PHP process functions missing writeMessageEnd()
This patch adds in the missing call.
Patch: Andrew Grumet
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1226892
Files :
* /thrift/trunk/compiler/cpp/src/generate/t_php_generator.cc
> Compiled PHP process functions missing writeMessageEnd()
> --------------------------------------------------------
>
> Key: THRIFT-1479
> URL: https://issues.apache.org/jira/browse/THRIFT-1479
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.8
> Reporter: Andrew Grumet
> Assignee: Andrew Grumet
> Fix For: 0.9
>
> Attachments: THRIFT-1479.patch
>
>
> While testing a PHP implementation of TJSONProtocol, we noticed that the
> process_* functions created by
> thrift -r --gen php:server
> were missing a call to
> $output->writeMessageEnd();
> This probably went unnoticed in testing to this point because
> TBinaryProtocol.php does not issue a message end marker. But with JSON, the
> message needs to be closed with a closing square bracket.
> The attached patch adds the message end call.
> Generated code has been tested with ThriftTest.thrift and TBinaryProtocol, as
> well as with our new JSON implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
