[
https://issues.apache.org/jira/browse/THRIFT-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187750#comment-13187750
]
Philippe STRAUSS commented on THRIFT-1488:
------------------------------------------
2.0.16 too, I've looked at your patch and made this one:
--- TNonblockingServer.cpp.orig 2012-01-17 16:14:45.000000000 +0100
+++ TNonblockingServer.cpp 2012-01-17 16:19:17.000000000 +0100
@@ -1429,7 +1429,7 @@
// mechanism to stop the thread, but happily if we're running in the
// same thread, this means the thread can't be blocking in the event
// loop either.
- if (!Thread::is_current(threadId_)) {
+ if (!Thread::is_current((pthread_t) threadId_)) {
notify(NULL);
}
}
TNonblockingServer.cpp and Thrift as a whole (with my configure invocation)
builds.
But physically far for a while of the location where I have a second computer
to test thrift now, hmm could cook something on localhost in case though.
Regards.
--
Philippe Strauss
http://www.philou.ch/
> src/concurrency/Thread.h:91:58: error: invalid conversion from 'pthread_t
> {aka _opaque_pthread_t*}' to 'apache::thrift::concurrency::Thread::id_t {aka
> long long unsigned int}' [-fpermissive]
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1488
> URL: https://issues.apache.org/jira/browse/THRIFT-1488
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.9
> Environment: Mac OSX 10.6.8 x86_64, up to date macports, apple gcc
> 4.2.1, genuine gnu gcc 4.5.3 and 4.6.2
> Reporter: Philippe STRAUSS
> Assignee: Jake Farrell
> Fix For: 0.9
>
> Attachments: config.log, thrift-1488.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> right after building the generators :
> Making all in lib
> Making all in cpp
> Making all in .
> /bin/sh ../../libtool --tag=CXX --mode=compile /opt/gnucc/bin/g++
> -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src -Wall -g -O2 -MT
> Thrift.lo -MD -MP -MF .deps/Thrift.Tpo -c -o Thrift.lo `test -f
> 'src/Thrift.cpp' || echo './'`src/Thrift.cpp
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT Thrift.lo -MD -MP -MF
> .deps/Thrift.Tpo -c src/Thrift.cpp -fno-common -DPIC -o .libs/Thrift.o
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT Thrift.lo -MD -MP -MF
> .deps/Thrift.Tpo -c src/Thrift.cpp -o Thrift.o >/dev/null 2>&1
> mv -f .deps/Thrift.Tpo .deps/Thrift.Plo
> /bin/sh ../../libtool --tag=CXX --mode=compile /opt/gnucc/bin/g++
> -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src -Wall -g -O2 -MT
> TApplicationException.lo -MD -MP -MF .deps/TApplicationException.Tpo -c -o
> TApplicationException.lo `test -f 'src/TApplicationException.cpp' || echo
> './'`src/TApplicationException.cpp
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT TApplicationException.lo -MD
> -MP -MF .deps/TApplicationException.Tpo -c src/TApplicationException.cpp
> -fno-common -DPIC -o .libs/TApplicationException.o
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT TApplicationException.lo -MD
> -MP -MF .deps/TApplicationException.Tpo -c src/TApplicationException.cpp -o
> TApplicationException.o >/dev/null 2>&1
> mv -f .deps/TApplicationException.Tpo .deps/TApplicationException.Plo
> /bin/sh ../../libtool --tag=CXX --mode=compile /opt/gnucc/bin/g++
> -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src -Wall -g -O2 -MT
> VirtualProfiling.lo -MD -MP -MF .deps/VirtualProfiling.Tpo -c -o
> VirtualProfiling.lo `test -f 'src/VirtualProfiling.cpp' || echo
> './'`src/VirtualProfiling.cpp
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT VirtualProfiling.lo -MD -MP -MF
> .deps/VirtualProfiling.Tpo -c src/VirtualProfiling.cpp -fno-common -DPIC -o
> .libs/VirtualProfiling.o
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT VirtualProfiling.lo -MD -MP -MF
> .deps/VirtualProfiling.Tpo -c src/VirtualProfiling.cpp -o VirtualProfiling.o
> >/dev/null 2>&1
> mv -f .deps/VirtualProfiling.Tpo .deps/VirtualProfiling.Plo
> /bin/sh ../../libtool --tag=CXX --mode=compile /opt/gnucc/bin/g++
> -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include -I./src -Wall -g -O2 -MT
> ThreadManager.lo -MD -MP -MF .deps/ThreadManager.Tpo -c -o ThreadManager.lo
> `test -f 'src/concurrency/ThreadManager.cpp' || echo
> './'`src/concurrency/ThreadManager.cpp
> libtool: compile: /opt/gnucc/bin/g++ -DHAVE_CONFIG_H -I. -I../..
> -I/opt/local/include -I./src -Wall -g -O2 -MT ThreadManager.lo -MD -MP -MF
> .deps/ThreadManager.Tpo -c src/concurrency/ThreadManager.cpp -fno-common
> -DPIC -o .libs/ThreadManager.o
> In file included from src/concurrency/ThreadManager.h:26:0,
> from src/concurrency/ThreadManager.cpp:24:
> src/concurrency/Thread.h: In static member function 'static
> apache::thrift::concurrency::Thread::id_t
> apache::thrift::concurrency::Thread::get_current()':
> src/concurrency/Thread.h:91:58: error: invalid conversion from 'pthread_t
> {aka _opaque_pthread_t*}' to 'apache::thrift::concurrency::Thread::id_t {aka
> long long unsigned int}' [-fpermissive]
> make[4]: *** [ThreadManager.lo] Error 1
> make[3]: *** [all-recursive] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
