[ 
https://issues.apache.org/jira/browse/THRIFT-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jon Stephens updated THRIFT-1501:
---------------------------------

          Description: 
(This is a continuation of THRIFT-1330 which I am unable to reopen.)
In the PHP, old-style namespaces are still broken for enums:

{noformat}
$ cat test.thrift 
namespace php TestNamespace
enum MyEnum {}
$ thrift -version
Thrift version 0.8.0
$ thrift --gen php test.thrift
$ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO NAMESPACE 
FOUND"
NO NAMESPACE FOUND
$ thrift6 -version
Thrift version 0.6.0
$ thrift6 --gen php test.thrift
$ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO NAMESPACE 
FOUND"
final class TestNamespace_MyEnum {
{noformat}


  was:
(This is a continuation of THRIFT-1330 which I am unable to reopen.)
In the PHP, old-style namespaces are still broken for enums:

{noformat}
$ cat test.thrift 
namespace php TestNamespace
enum MyEnum {}
$ thrift -version
Thrift version 0.8.0
# Issue can also be reproduced with "Thrift version 0.9.0-dev" - trunk as of 
this writing
$ thrift --gen php test.thrift
$ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO NAMESPACE 
FOUND"
NO NAMESPACE FOUND
$ thrift6 -version
Thrift version 0.6.0
$ thrift6 --gen php test.thrift
$ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO NAMESPACE 
FOUND"
final class TestNamespace_MyEnum {
{noformat}


    Affects Version/s:     (was: 0.9)

Edit: I'm an idiot and can't type this issue is fixed in trunk.
                
> PHP old namespaces not generated for enums
> ------------------------------------------
>
>                 Key: THRIFT-1501
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1501
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.7, 0.8
>            Reporter: Jon Stephens
>
> (This is a continuation of THRIFT-1330 which I am unable to reopen.)
> In the PHP, old-style namespaces are still broken for enums:
> {noformat}
> $ cat test.thrift 
> namespace php TestNamespace
> enum MyEnum {}
> $ thrift -version
> Thrift version 0.8.0
> $ thrift --gen php test.thrift
> $ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO 
> NAMESPACE FOUND"
> NO NAMESPACE FOUND
> $ thrift6 -version
> Thrift version 0.6.0
> $ thrift6 --gen php test.thrift
> $ grep "class TestNamespace" gen-php/test/test_types.php || echo "NO 
> NAMESPACE FOUND"
> final class TestNamespace_MyEnum {
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to