[ 
https://issues.apache.org/jira/browse/THRIFT-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201639#comment-13201639
 ] 

Hudson commented on THRIFT-1512:
--------------------------------

Integrated in Thrift #401 (See [https://builds.apache.org/job/Thrift/401/])
    THRIFT-1512 Thrift socket support for Windows XP
Patch: Peace C

roger : http://svn.apache.org/viewvc/?view=rev&rev=1241171
Files : 
* /thrift/trunk/lib/cpp/README_WINDOWS
* /thrift/trunk/lib/cpp/src/windows/TargetVersion.h
* /thrift/trunk/lib/cpp/src/windows/config.h
* /thrift/trunk/lib/cpp/src/windows/force_inc.h

                
> Thrift socket support for Windows XP
> ------------------------------------
>
>                 Key: THRIFT-1512
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1512
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.8
>         Environment: Windows XP, Visual Studio
>            Reporter: Peace C
>            Assignee: Peace C
>              Labels: msvc, thrift,, windows, xp
>             Fix For: 0.9
>
>         Attachments: Thrift_XP_skt_UNIXEOL.patch
>
>
> This is a follow-up patch to THRIFT-1490. The previous code would never 
> follow the Windows XP path (WINVER 0x0501). At least that appears to be the 
> case since poll_win32() was incomplete and not functional. Windows' version 
> of select() does not set the revents field so FD_ISSET is used to determine 
> how to manually set it.  I've tested this on a sample project and it's 
> working as expected. config.h is now targeting XP for wider compatibility. If 
> this isn't desired or you don't trust the new code, comment out the two 
> #define lines toward the top and it will revert to targeting Vista/Win7.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to