[ 
https://issues.apache.org/jira/browse/THRIFT-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235452#comment-13235452
 ] 

Hudson commented on THRIFT-1532:
--------------------------------

Integrated in Thrift #428 (See [https://builds.apache.org/job/Thrift/428/])
    THRIFT-1532 - slightly better fix, take into account requiredness when 
adding default values (Revision 1303666)

     Result = SUCCESS
molinaro : http://svn.apache.org/viewvc/?view=rev&rev=1303666
Files : 
* /thrift/trunk/compiler/cpp/src/generate/t_erl_generator.cc
* /thrift/trunk/lib/erl/test/Thrift1475.thrift

                
> The type specifications in the generated Erlang code should include 
> "undefined" where it's used as a default value
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1532
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1532
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Erlang - Compiler
>    Affects Versions: 0.8
>         Environment: Erlang/OTP R15B.
>            Reporter: Björn Bylander
>            Assignee: Anthony Molinaro
>            Priority: Minor
>              Labels: compiler, dialyzer, erlang, specification, type
>             Fix For: 0.9
>
>         Attachments: THRIFT-1532_t_erl_generator.cc.patch, agent.tar.gz
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The Erlang code generated by the compiler for, for example, an integer field 
> of a struct sets a default value of 'undefined' but the type to just 
> 'integer()' which doesn't include the default value. This makes Dialyzer 
> complain if the field has not been initialized as it gets set to 'undefined' 
> instead of an integer value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to