[ https://issues.apache.org/jira/browse/THRIFT-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251985#comment-13251985 ]
Hudson commented on THRIFT-1562: -------------------------------- Integrated in Thrift #433 (See [https://builds.apache.org/job/Thrift/433/]) THRIFT-1562 Fix issue with TFramedTransport::readSlow Patch: Dave Watson (Revision 1325034) Result = FAILURE roger : http://svn.apache.org/viewvc/?view=rev&rev=1325034 Files : * /thrift/trunk/lib/cpp/src/transport/TBufferTransports.cpp * /thrift/trunk/lib/cpp/src/transport/TZlibTransport.h * /thrift/trunk/lib/cpp/test/TransportTest.cpp > Fix issue with TFramedTransport::readSlow > ------------------------------------------ > > Key: THRIFT-1562 > URL: https://issues.apache.org/jira/browse/THRIFT-1562 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Reporter: Dave Watson > Assignee: Dave Watson > Priority: Minor > Attachments: 0003-Fix-issue-with-TFramedTransport-readSlow.patch > > > From 2744bf68037f7403af6875e7a1afa8966265de30 Mon Sep 17 00:00:00 2001 > From: Sanketh Indarapu <sank...@fb.com> > Date: Mon, 30 Aug 2010 23:59:35 +0000 > Subject: [PATCH 03/12] Fix issue with TFramedTransport::readSlow > Summary: > When testing a zlib transport over the standard tframedtransport, there was an > issue where the client would block, because tframedtransport did not return > buffered data and attempted to instead read a new frame to satisfy the read. > This diff fixes the issue and adds a test to thrift TransportTest to check for > this case. > Test Plan: > 1. Add a new test to TransportTest, verify that it fails without this fix, and > passes afterwards. > 2. Run a server with zlibtransport over tframedtransport in the > configuration that showed this bug originally and verify the client no longer > blocks and can successfully retrieve counters from the server. > 3. Canaried for an hour in production and verified that there were no major > issues and no changes in number of thrift diagnostics/errors. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira