Thrift/cpp: Use some different string operations in ----------------------------------------------------
Key: THRIFT-1566 URL: https://issues.apache.org/jira/browse/THRIFT-1566 Project: Thrift Issue Type: Improvement Components: C++ - Library Reporter: Dave Watson Priority: Minor >From 46f150e9d77e7cdabefbe5eb8bba54abe0af2a98 Mon Sep 17 00:00:00 2001 From: David Reiss <dre...@fb.com> Date: Fri, 10 Sep 2010 04:03:44 +0000 Subject: [PATCH 08/12] Thrift/cpp: Use some different string operations in TBinaryProtocol Summary: - Replace str = "" with str.clear(). Might be a bit faster. Definitely clearer (no pun intended). - Replace str = std::string(data, size) with str.assign(data, size). Definitely clearer. Probably faster. - Simplifies an upcoming diff. Test Plan: Built some code. DiffCamp Revision: 155272 Commenters: aalexandre CC: aalexandre, nschrenk, thrift-team@lists Revert Plan: ok git-svn-id: svn+ssh://tubbs/svnapps/fbomb/trunk/[internal fb thing]@37641 2248de34-8caa-4a3c-bc55-5e52d9d7b73a --- lib/cpp/src/protocol/TBinaryProtocol.tcc | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira