[ 
https://issues.apache.org/jira/browse/THRIFT-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Grumet updated THRIFT-1514:
----------------------------------

    Attachment: THRIFT-1514.patch

The attached patch passes the unit tests for jquery 1.5, 1.6 and 1.7.

We removed the extra layer of deferreds, using a custom jQuery ajax converter 
to deserialize thrift objects.

Instead of returning a custom deferred, we instead return the XHR itself, which 
exposes the same promise interface.

The patch introduces a minor difference from previous versions.  Namely, the 
thrift exception object is now the third argument passed to error() callbacks, 
instead of the first.  This ordering comes from the jQuery.ajax itself, which 
invokes error callbacks with [jXHR, statusText, error].
                
> Callbacks with newer jQuery versions don't work
> -----------------------------------------------
>
>                 Key: THRIFT-1514
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1514
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.9
>            Reporter: Kenny
>            Priority: Minor
>         Attachments: THRIFT-1514.patch
>
>
> When using jQuery 1.7.1 callbacks don't work. The following error is returned:
> TypeError: Object function ( selector, context ) { // The jQuery object is 
> actually just the init constructor 'enhanced' return new jQuery.fn.init( 
> selector, context, rootjQuery ); } has no method '_Deferred'
> It seems _Deferred no longer exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to