[
https://issues.apache.org/jira/browse/THRIFT-541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-541.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.9
rebased for trunk and committed. thanks for the patch
> Cocoa code generator doesn't put keywords before all arguments.
> ---------------------------------------------------------------
>
> Key: THRIFT-541
> URL: https://issues.apache.org/jira/browse/THRIFT-541
> Project: Thrift
> Issue Type: Improvement
> Components: Cocoa - Compiler
> Reporter: Matt Ronge
> Assignee: Andrew McGeachie
> Priority: Minor
> Fix For: 0.9
>
> Attachments: arg_name_fix.patch
>
>
> The compiler doesn't put keywords in front of all args. Per Cocoa coding
> conventions
> (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH)
> all args should have a keyword.
> Currently this would be generated
> - (int32_t) calculate: (int32_t) logid : (Work *) w;
> But this is better
> - (int32_t) calculate: (int32_t) logid w: (Work *) w;
> Attached is a very small patch that uses the name of the arg variable as the
> keyword.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
