[
https://issues.apache.org/jira/browse/THRIFT-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397480#comment-13397480
]
Andrew Majorov commented on THRIFT-1626:
----------------------------------------
Great news!
> concurrency::Mutex timedlock fix and lesser improvements
> --------------------------------------------------------
>
> Key: THRIFT-1626
> URL: https://issues.apache.org/jira/browse/THRIFT-1626
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.8, 0.9
> Reporter: Andrew Majorov
> Labels: patch
> Attachments: thrift_timedlock_fix_improvements.patch
>
>
> Thrift concurrency::Mutex have had its timedlock implemented slightly wrong.
> Patched it. Added a pretty simple emulation when a platform does not provide
> pthread_mutex_timedlock. The solution seems to be close to the one used in
> Mono for Android. Manually tested under android-8, works fine.
> Patch summary:
> - Correct timed lock timeouts and emulation on platforms where it is not
> supported.
> - Header config.h now being included conditionally as it supposed to.
> - Make internally used preprocessor definition names more specific and more
> likely to be unique.
> This will suppress error messages and wrong endianness deduction when
> compiling Thrift core C++
> library on Android.
> - Reorder header inclusion to ensure config.h will always be included before
> any platform stuff.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
