[ 
https://issues.apache.org/jira/browse/THRIFT-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422717#comment-13422717
 ] 

Dan Cromer commented on THRIFT-1551:
------------------------------------

+1 to this.  This is a pretty major issue!
                
> 2 thrift file define only struct (no service), one include another, the gen 
> nodejs file didn't have "requires" at the top
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1551
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1551
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Compiler
>    Affects Versions: 1.0
>         Environment: ubuntu 11.10
>            Reporter: Mars Hsu
>             Fix For: 1.0
>
>
> I talk Wade Simmons with this issue today
> Mars
> hi wade,do you got my email?
> 下午2:57
> Wade
> yes, what version of thrift are you using?
> Mars
> 0.8.0
> the lastest
> it seems, the bug didn't fix
> Wade
> hmm, that is strange, it should have that patch merged
> perhaps it is a different issue
> 下午2:59
> Mars
> two struct defined thrife, one include another, the gen nodejs file, didn't 
> have reqiured ttypes at the top of file
> i think they are same issue
> 下午3:01
> Wade
> the code from that ticket has been merged in, so there must be a bug that you 
> are running into that wasn't tested as part of that patch
> not sure what the issue is that you are hitting though
> you might need to open a new ticket with example files
> 下午3:12
> Wade
> oh, are you defining  a thrift service?
> or just a thrift struct?
> 下午3:14
> Wade
> the current code until works with a service that extends another service
> Mars
> yes, just 2 thrift file, with only structs, the service define in 
> *_service.thrift, I checkout the include of file with service defined is work 
> fine
> Wade
> yeah, there is a bug with structs that extend other structs it looks like
> you should open a new bug

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to