[ 
https://issues.apache.org/jira/browse/THRIFT-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Brauer updated THRIFT-1671:
-------------------------------

    Description: 
In THRIFT-541 keywords where introduced to method declarations. But the actual 
call to the method omits them. That leads to errors as:
{noformat}
pages.m:2558:3: warning: instance method '-send_deletePage::' not found (return 
type defaults to 'id')
  [self send_deletePage: websiteId : pageId];
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pages.m:2764:23: warning: instance method '-getPage::' not found (return type 
defaults to 'id')
  [result setSuccess: [mService getPage: [args websiteId]: [args pageId]]];
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pages.m:2781:3: warning: instance method '-deletePage::' not found (return type 
defaults to 'id')
  [mService deletePage: [args websiteId]: [args pageId]];
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{noformat}

The attached patch fixes that.

  was:
In THRIFT-541 keywords where introduced to method declarations. But the actual 
call to the method omits them. That leads to errors as:
{{{
pages.m:2558:3: warning: instance method '-send_deletePage::' not found (return 
type defaults to 'id')
  [self send_deletePage: websiteId : pageId];
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pages.m:2764:23: warning: instance method '-getPage::' not found (return type 
defaults to 'id')
  [result setSuccess: [mService getPage: [args websiteId]: [args pageId]]];
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pages.m:2781:3: warning: instance method '-deletePage::' not found (return type 
defaults to 'id')
  [mService deletePage: [args websiteId]: [args pageId]];
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
}}}

The attached patch fixes that.

    
> Cocoa code generator does not put keywords into generated method calls
> ----------------------------------------------------------------------
>
>                 Key: THRIFT-1671
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1671
>             Project: Thrift
>          Issue Type: Bug
>          Components: Cocoa - Compiler
>    Affects Versions: 0.9
>            Reporter: Jan Brauer
>         Attachments: argument_for_method_calls.patch
>
>
> In THRIFT-541 keywords where introduced to method declarations. But the 
> actual call to the method omits them. That leads to errors as:
> {noformat}
> pages.m:2558:3: warning: instance method '-send_deletePage::' not found 
> (return type defaults to 'id')
>   [self send_deletePage: websiteId : pageId];
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pages.m:2764:23: warning: instance method '-getPage::' not found (return type 
> defaults to 'id')
>   [result setSuccess: [mService getPage: [args websiteId]: [args pageId]]];
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> pages.m:2781:3: warning: instance method '-deletePage::' not found (return 
> type defaults to 'id')
>   [mService deletePage: [args websiteId]: [args pageId]];
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> {noformat}
> The attached patch fixes that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to