[ https://issues.apache.org/jira/browse/THRIFT-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465540#comment-13465540 ]
Jake Farrell commented on THRIFT-1356: -------------------------------------- Matthew, Thank you for your work on this issue. Please see http://thrift.apache.org/docs/HowToContribute/ for contributing patches > Memory leak and other issues in TSocketClient > --------------------------------------------- > > Key: THRIFT-1356 > URL: https://issues.apache.org/jira/browse/THRIFT-1356 > Project: Thrift > Issue Type: Bug > Components: Cocoa - Library > Affects Versions: 0.7 > Environment: iOS 4.3 > Reporter: Matthew Phillips > Attachments: TSocketClient.m > > > The socket setup code in TSocketClient seems to have been copied blindly from > Apple's docs. The two problems with that are: > (a) The example is for non-blocking event-based network IO, but Thrift uses > it in blocking mode and does not handle the delegate events it registers for. > This causes network operations to randomly hang. > (b) It retains the input and output streams, which already have a retain > count of 1, and which are then retained again by the superclass, causing a > memory leak. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira