[
https://issues.apache.org/jira/browse/THRIFT-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1718.
--------------------------------
Resolution: Fixed
Assignee: Diwaker Gupta (was: Jake Farrell)
committed, thanks
> Incorrect check in TFileTransportTest
> -------------------------------------
>
> Key: THRIFT-1718
> URL: https://issues.apache.org/jira/browse/THRIFT-1718
> Project: Thrift
> Issue Type: Test
> Components: C++ - Library
> Affects Versions: 0.8
> Reporter: Diwaker Gupta
> Assignee: Diwaker Gupta
> Priority: Minor
> Fix For: 0.9
>
> Attachments: THRIFT-1718.patch
>
>
> TFileTransport:282, comment says:
> " // Make sure TFileTransport called fsync at least once"
> However, the test checks for greater than, resulting in failures.
> This diff brings the check in line with the comment and fixes the failing
> tests:
> {code}
> --- lib/cpp/test/TFileTransportTest.cpp
> +++ lib/cpp/test/TFileTransportTest.cpp
> @@ -278,7 +278,7 @@ void test_flush_max_us_impl(uint32_t flush_us, uint32_t
> write_us,
> const FsyncLog::CallList* calls = log.getCalls();
> // We added 1 fsync call above.
> // Make sure TFileTransport called fsync at least once
> - BOOST_CHECK_GT(calls->size(),
> + BOOST_CHECK_GE(calls->size(),
> static_cast<FsyncLog::CallList::size_type>(1));
>
> const struct timeval* prev_time = NULL;
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
