[ 
https://issues.apache.org/jira/browse/THRIFT-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472922#comment-13472922
 ] 

Hudson commented on THRIFT-1643:
--------------------------------

Integrated in Thrift #560 (See [https://builds.apache.org/job/Thrift/560/])
    THRIFT-1643 Denial of Service attack in TBinaryProtocol.readString
Patch: Niraj Tolia
Fix:   add TCompactProtocol maxNetworkBytes (Revision 1396186)

     Result = ABORTED
roger : http://svn.apache.org/viewvc/?view=rev&rev=1396186
Files : 
* /thrift/trunk/lib/java/src/org/apache/thrift/protocol/TCompactProtocol.java

                
> Denial of Service attack in TBinaryProtocol.readString
> ------------------------------------------------------
>
>                 Key: THRIFT-1643
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1643
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.6.1, 0.8
>         Environment: All
>            Reporter: Devesh Parekh
>            Assignee: Roger Meier
>            Priority: Critical
>              Labels: security
>         Attachments: 
> 0001-Address-denial-of-service-in-TCompactProtocol.patch, 
> 0001-Add-test-for-TCompactProtocol-OOM-Denial-of-Service.patch, 
> 0002-Add-test-for-TBinaryProtocol-OOM-Denial-of-Service.patch, 
> 0003-Cleanup-length-checks-in-TCompactProtocol.patch, Attack.java, Foo.thrift
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In readString, if the string field's size is greater than the number of bytes 
> remaining in the byte array to deserialize, libthrift will happily allocate a 
> byte array of that size in readStringBody, filling the heap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to