[
https://issues.apache.org/jira/browse/THRIFT-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477052#comment-13477052
]
Matt T. Proud commented on THRIFT-1600:
---------------------------------------
Hi Jed,
My efforts have been at a real stand-still for the past few weeks. All of my
upstream changes into Aalok Shah's thrift4go have been merged in. There is
continuous integration as well as an extensive interoperability and generation
validation test suites now. We should have strong confidence in the system now.
To that end, Geert-Johan (https://github.com/GeertJohan/thrift4go) has
discovered a couple of additional bugs in thrift4go that were unrelated to my
changes but affect Thrift's support Go support for generated code in cases
where ENUMs are used in the generic containers—e.g., MAP, LIST.
Where do things stand now?
1.) The current Go support in upstream Thrift is categorically incompatible
with the accepted stable release of the Go platform. Taking what is in
thrift4go should be satisfactory.
2.) Geert-Johan is fixing some corner case problems:
https://github.com/GeertJohan/thrift4go and is merging in his fixes into the
canonical source. I would let him continue in the interim. Consider just
merging in his subsequent changes into a point release, maybe.
3.) My feeling is that the lack of useful Go support right now is actually
hindering future development and improvement of the Thrift ecosystem in Go. If
you snapshot what exists now, folks have an opportunity to at least use the
thing now. That is a real win for everybody.
> Thrift Go Compiler and Library out of date with Go 1 Release.
> -------------------------------------------------------------
>
> Key: THRIFT-1600
> URL: https://issues.apache.org/jira/browse/THRIFT-1600
> Project: Thrift
> Issue Type: Bug
> Components: Go - Compiler, Go - Library
> Reporter: Atul S Vasu
> Attachments: partial.diff, thrift-1600-go1-support.patch.gz
>
>
> Go 1 is a major release of Go that will be stable in the long term. Read the
> Go 1 Release Notes for more information.
> http://golang.org/doc/go1.html
> The current (trunk) compiler and libraries are not compatible with Go1,
> because of significant changes in the language.
> The pomack/thrift4go seems a valid patch, but doesn't seem to be pulled into
> Apache Thrift. Possibly merge the development into one place?
> https://github.com/pomack/thrift4go
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
