[ 
https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482092#comment-13482092
 ] 

Hudson commented on THRIFT-1353:
--------------------------------

Integrated in Thrift #571 (See [https://builds.apache.org/job/Thrift/571/])
    Thrift-1353: Switch to performance branch, get rid of BinaryParser
Client: Node.js
Patch: Wade Simmons

"binary" fields will be returned as Buffers instead of Strings
"int64" fields will be returned as http://github.com/broofa/node-int64 objects 
(Revision 1401081)

     Result = ABORTED
                
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
>                 Key: THRIFT-1353
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1353
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.7
>            Reporter: Hans Duedal
>            Assignee: Henrique Mendonca
>              Labels: node, nodejs
>             Fix For: 1.0
>
>         Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at 
> https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the 
> performance branch seems focused on this very issue. Also it includes the 
> excellent int64 implementation from broofa. What's not to like?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to