[ 
https://issues.apache.org/jira/browse/THRIFT-1706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500638#comment-13500638
 ] 

Kevin Radloff commented on THRIFT-1706:
---------------------------------------

Ooh, I see. In my case I was simply doing it wrong, not providing an error 
handler and/or expecting it to take one argument instead of three. In my case, 
I'm concerned about thrift-generated-API exceptions returned by the server, and 
so these are raised just fine in all circumstances, even for CORS (since the 
request has to have completed successfully for them to trigger). Thanks for 
pointing me at the existing test.
                
> jquery ajax code doesn't handle exceptions
> ------------------------------------------
>
>                 Key: THRIFT-1706
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1706
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.9
>            Reporter: Kevin Radloff
>
> The converter function inside of the jquery ajax handler makes no 
> accommodations for exceptions that may be thrown during the normal course of 
> running "recv_method.call()" for a remote method that raises an exception. If 
> this happens, the result gets lost as the normal ajax response handling is 
> aborted.
> It seems like the converter function should at the very least have a 
> try/catch block that sets the exception as the ajax result in the place of a 
> regular thrift type/object. It might be best to have some sort of interface 
> that takes both a callback and errback, however, so as to not require 
> introspection into the result.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to