[ 
https://issues.apache.org/jira/browse/THRIFT-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505913#comment-13505913
 ] 

Jens Geyer commented on THRIFT-1699:
------------------------------------

Kevin,
you write, you are using an own impl. of the JSON protocol. 

The ruby code in the repo does also do something in this function:
{code}
    def read_field_end
      read_json_object_end
    end
{code}

Question: Does the JSON implementation in the repo work or not? 
=> If yes, the issue is most probably within your code. 
=> If not, there's a big chance that you are right.

Without having done deep dive into the Ruby code, just taken a quick look at 
it. So I may overlook something important.



                
> Native Union#read has extra read_field_end call
> -----------------------------------------------
>
>                 Key: THRIFT-1699
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1699
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.8
>            Reporter: Kevin Radloff
>         Attachments: struct.diff
>
>
> The native implementation of the Union#read method has an extraneous call to 
> read_field_end. This makes no difference to most protocols because 
> read_field_end is a no-op, but it breaks JSON (in this case my own class, not 
> the one in trunk), which does do something in this method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to