[ 
https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507543#comment-13507543
 ] 

Nathan Beyer commented on THRIFT-1766:
--------------------------------------

Interestingly, the patch does enable the 'binary' type for the JSON protocol. 
For whatever reason, the JSONProtocol class implemented read_binary and 
write_binary methods, but prior to this patch, they would have never been 
invoked. From what I can tell, they seem to line up with code in the C++ and 
Java libraries.
                
> [Ruby] Provide support for binary types
> ---------------------------------------
>
>                 Key: THRIFT-1766
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1766
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9
>            Reporter: Nathan Beyer
>         Attachments: THRIFT-1766-provide-support-for-binary-types.patch
>
>
> The Ruby library didn't provide explicit support for 'binary' types, which 
> sort of worked on Ruby 1.8.7 and with Thrift 0.8, but it doesn't work with 
> Ruby 1.9.3 and the encoding changes that were included with Thrift 0.9.
> This issue is intended to provide first class support for the 'binary' type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to