[ https://issues.apache.org/jira/browse/THRIFT-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529414#comment-13529414 ]
Jens Geyer commented on THRIFT-1768: ------------------------------------ I'd like to have a second opinion on the patch, as it affects all languages. > unions can't have required fields (Compiler) > -------------------------------------------- > > Key: THRIFT-1768 > URL: https://issues.apache.org/jira/browse/THRIFT-1768 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) > Affects Versions: 0.8, 0.9 > Reporter: Jens Geyer > Assignee: Jens Geyer > Fix For: 1.0 > > Attachments: THRIFT-1768_unions_cant_have_required_fields_Compiler - > rev1.patch > > > Required fields within unions should issue a warning. First, required makes > not much sense with unions. Next, most languages are already treating them as > optional anyway, effectively ignoring the required attribute. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira