[ https://issues.apache.org/jira/browse/THRIFT-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544095#comment-13544095 ]
Jens Geyer commented on THRIFT-1815: ------------------------------------ +1 for the patch (y) There's just one minor thing left ... http://thrift.apache.org/docs/HowToContribute Thank you! > Code generators line buffer output > ---------------------------------- > > Key: THRIFT-1815 > URL: https://issues.apache.org/jira/browse/THRIFT-1815 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Affects Versions: 0.9 > Reporter: Andrew Gaul > Labels: performance > > This results in slow performance on FUSE- and network-based filesystems, > e.g., eCryptfs. std::ostream << std::endl emits a newline and flushes > buffers to the kernel[1], yielding excessive system calls. Instead, emit > "\n" which does the equivalent without the flush[2]. The attached patch > accomplishes this while minimizing code churn by removing "using namespace > std" and introducing a static variable endl. > [1] http://www.cplusplus.com/reference/ios/endl/ > [2] > http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira