[ 
https://issues.apache.org/jira/browse/THRIFT-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547622#comment-13547622
 ] 

易剑 commented on THRIFT-1824:
----------------------------

Maybe config.h should be removed from include directory, we should not
include config.h in public header files.


2013/1/8 Ben Craig (JIRA) <j...@apache.org>



-- 
Hadoop Forum: http://www.hadoopor.com
Open mooon: http://code.google.com/p/mooom

                
> many compile warning, becase Thread.h includes config.h
> -------------------------------------------------------
>
>                 Key: THRIFT-1824
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1824
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: 2.6.32.43 x86_64 x86_64 x86_64 GNU/Linux
> automake (GNU automake) 1.9.6
> autoconf (GNU Autoconf) 2.59
> autoheader (GNU Autoconf) 2.59
>            Reporter: Jian Yi
>              Labels: patch
>             Fix For: 1.2
>
>         Attachments: Thread.h, Thread.h.diff
>
>
> many compile warning, becase Thread.h includes config.h
> #ifdef HAVE_CONFIG_H
> //#include <config.h> // fix: commented out it
> #endif

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to