[ https://issues.apache.org/jira/browse/THRIFT-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549661#comment-13549661 ]
Chao Shi commented on THRIFT-1816: ---------------------------------- Yes, it should work against the git master. Let me demo it with the following case: a.thrift struct A { 1: i32 n; } b.thrift include "a.thrift" struct B { 1: a.A a; } The compiler with my patch will generate an extra "require" line in b_types.js: var a_ttypes = require('./a_types') > Need "require" included thrift files in "xxx_types.js" > ------------------------------------------------------ > > Key: THRIFT-1816 > URL: https://issues.apache.org/jira/browse/THRIFT-1816 > Project: Thrift > Issue Type: Bug > Components: Node.js - Compiler > Reporter: Chao Shi > Attachments: thrift-1816.patch > > > Currently the compiler for nodejs only generate require statement in each > service js. It is also needed in the "types" js. I have a patch for this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira