[ https://issues.apache.org/jira/browse/THRIFT-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558497#comment-13558497 ]
Ben Craig commented on THRIFT-1740: ----------------------------------- I wasn't doing testing with cob_style when I made this patch. If it causes the generated code to pull in tr1/functional, then it would be reasonable to make that code pull in cxxfunctional.h instead. > Make C++ library build on OS X and iOS > -------------------------------------- > > Key: THRIFT-1740 > URL: https://issues.apache.org/jira/browse/THRIFT-1740 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.9, 1.0 > Environment: Patch fixes OS X xcode 3.2 with gcc 4.2 toolchain. Also > fixes iOS xcode 4.4 with clang 4.0 toolchain. > Reporter: Ben Craig > Assignee: Ben Craig > Labels: c++, ios, mac > Fix For: 0.9, 1.0 > > Attachments: mac_and_ios.patch > > > Various small issues keep the existing Thrift c++ libraries from building on > OS X and iOS. For example, in Clang, there is no <tr1/functional>, only a > regular <functional>. Instead of adding a new configure token and a million > #ifdefs, the patch has added a wrapper header that throws the relevant > <functional> symbols into the apache::thrift:stdcxx namespace. > There are also several fixes for unused variable warnings in release mode. I > have added a helper macro to better document these cases (as opposed to just > adding the mysterious "ret=ret;" everywhere). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira