[ 
https://issues.apache.org/jira/browse/THRIFT-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580935#comment-13580935
 ] 

Jake Farrell commented on THRIFT-1856:
--------------------------------------

On OS X the Maps key and value where being marked with required and optional 
comments within the serialize and deserialize functions, on linux the lex 
compiler is setting the optional flag on maps value field differently. The 
patch moved the optional or required comment to only be in the initial 
declaration of the variables defined in the idl and removes the comments from 
internally generated variables. 
                
> different comments generated on OSX vs Linux/Windows
> ----------------------------------------------------
>
>                 Key: THRIFT-1856
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1856
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Compiler
>    Affects Versions: 0.9, 1.0
>         Environment: OSX 10.7
> Ubuntu 12.04
>            Reporter: Vitali Lovich
>            Assignee: Jake Farrell
>         Attachments: mytest.thrift, Test.java.linux, Test.java.osx
>
>
> Compiling the same thrift definition on OSX & Linux produces two slightly 
> different outputs.  Since our thrift files are committed in the repository, 
> it makes it annoying to develop on OSX.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to