[
https://issues.apache.org/jira/browse/THRIFT-1890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604120#comment-13604120
]
Ben Craig commented on THRIFT-1890:
-----------------------------------
This will probably fix THRIFT-1777.
I hope to be able to test Jens's patch on Monday.
Main oddity I saw in my quick review of the code was the cleanup of the
overlapped.hevent. That would probably be handled better by having an object
destructor clean it up at the end of acceptImpl. overlapped.hevent and the
"cleanup" object would both have a handle to the same event.
> C++: Make named pipes server work asynchronously
> -------------------------------------------------
>
> Key: THRIFT-1890
> URL: https://issues.apache.org/jira/browse/THRIFT-1890
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Environment: Windows
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 1.0
>
> Attachments:
> THRIFT-1890_Cpp_Make_named_pipes_server_work_asynchronously.patch
>
>
> Currently the named pipe server cannot be stopped gracefully due to the way
> ConnectNamedPipe() works for synchronous named pipes. The recommended
> solution is to run the pipe in "overlapped" mode, allowing the transport to
> be closed cleanly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
