[ 
https://issues.apache.org/jira/browse/THRIFT-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610989#comment-13610989
 ] 

Evan Nemerson commented on THRIFT-1879:
---------------------------------------

On what?  This is worthless without THRIFT-1883.  GObject Introspection 
requires you to annotate the code (see 
https://live.gnome.org/GObjectIntrospection/Annotations) so it knows things 
like when to transfer ownership, parameter direction, generic container types, 
etc., and in order to do that you have to use GTK-Doc style comments.  This 
could be used without THRIFT-1882, but if that's going to happen it makes much 
more sense to do it first.

That said, I'm actually having second thoughts about this (and THRIFT-1885).  
I'm in the middle of writing a new implementation (see 
http://mail-archives.apache.org/mod_mbox/thrift-dev/201303.mbox/browser for 
some of the reasons why), and I'd rather use the Thrift namespace for that 
instead of c_glib.  I could change the namespace on this patch to something 
else (ThriftGLib, maybe), but if something better is coming I don't see much 
gain in exposing c_glib to other languages.
                
> Add support for GObject-Introspection
> -------------------------------------
>
>                 Key: THRIFT-1879
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1879
>             Project: Thrift
>          Issue Type: New Feature
>          Components: C glib - Library
>            Reporter: Evan Nemerson
>         Attachments: 
> 0001-Move-typedefs-before-public-structs-to-work-around-g.patch, 
> 0005-THRIFT-1879-Add-GObject-Introspection-support.patch
>
>
> It would be nice if thrift_c_glib bindings supported GObject Introspection 
> (see https://live.gnome.org/GObjectIntrospection).  This would make Vala 
> bindings (THRIFT-1741) easy.
> Actually adding G-I is pretty easy (I already have a patch to do it), but 
> would require migrating the documentation to the gtk-doc format, so before I 
> invest the time I'd like to make sure this is something you're interested in.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to