[
https://issues.apache.org/jira/browse/THRIFT-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1823.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.0
Assignee: Simon South
Thanks for the patch, committed
> Missing parenthesis breaks "IS_..." macro in generated code
> -----------------------------------------------------------
>
> Key: THRIFT-1823
> URL: https://issues.apache.org/jira/browse/THRIFT-1823
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Compiler
> Affects Versions: 0.9
> Environment: CentOS 6.3 on x86 (32-bit)
> Reporter: Simon South
> Assignee: Simon South
> Priority: Minor
> Fix For: 1.0
>
> Attachments: thrift-1823-generate-is-macro-correctly.patch
>
>
> A missing parenthesis in the generated header file for a service interface
> breaks the "IS_..." macro, making client code that uses it fail to compile
> with messages like
> hello_world_processor.c:41:59: error: macro "G_TYPE_CHECK_INSTANCE_TYPE"
> requires 2 arguments, but only 1 given
> hello_world_processor.c:101:1: error: unterminated argument list invoking
> macro "G_LIKELY"
> In file included from /usr/include/glib-2.0/glib.h:79,
> from /usr/include/glib-2.0/gobject/gtype.h:26,
> from /usr/include/glib-2.0/gobject/gboxed.h:26,
> from /usr/include/glib-2.0/glib-object.h:25,
> from hello_world_processor.h:4,
> from hello_world_processor.c:1:
> I'll attach a patch with the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
