[ 
https://issues.apache.org/jira/browse/THRIFT-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617259#comment-13617259
 ] 

Hudson commented on THRIFT-1904:
--------------------------------

Integrated in Thrift #636 (See [https://builds.apache.org/job/Thrift/636/])
    THRIFT-1904 Incorrect code is generated for typedefs which use included 
types (Revision 45766049e0ed4e7fbef11e79ef417a6f970ba696)

     Result = ABORTED
jensg : 
https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=45766049e0ed4e7fbef11e79ef417a6f970ba696
Files : 
* compiler/cpp/src/generate/t_delphi_generator.cc

                
> Incorrect code is generated for typedefs which use included types
> -----------------------------------------------------------------
>
>                 Key: THRIFT-1904
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1904
>             Project: Thrift
>          Issue Type: Bug
>          Components: Delphi - Compiler
>         Environment: Windows
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 1.0
>
>         Attachments: 
> THRIFT-1904_Incorrect_code_is_generated_for_typedefs_which_use_included_types.patch
>
>
> If a typedef refers to a type that is defined in an included IDL file, the 
> code for the typedef is not generated. Furthermore, the Compiler issues a 
> warning about pending typedefs.
> If the typedef is used elsewhere in the code, the generated code cannot be 
> compiled because of the missing code for the pending typedefs.
> Inner IDL file:
> {code}
> namespace * bug.Uncompileable.Inner
> struct InnerStruct { }
> {code}
> Outer IDL file:
> {code}
> namespace * bug.Uncompileable.Outer
> include "bug_codegen_inner.thrift"
> struct AnotherStruct
> {
> }
> typedef bug_codegen_inner.InnerStruct OuterStruct
> typedef AnotherStruct AnotherRedefined
> struct OuterContainer {
>   1: AnotherRedefined MoreData
>   2: OuterStruct  SomeData
> }
> {code}
> In this example, the typedef for OuterStruct is not generated, thus Delphi 
> fails to compile OuterContainer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to