[ 
https://issues.apache.org/jira/browse/THRIFT-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jake Farrell updated THRIFT-1824:
---------------------------------

    Attachment: THRIFT-1824.patch

configure.ac line 577  AC_CONFIG_HEADERS(config.h:config.hin) is what generates 
the config.h file using autoheader. 

This is a known problem for projects using autotools and has come up before in 
THRIFT-705 where we went with the addition of ifdef HAVE_CONFIG_H. There are 26 
checks for this header in the lib/{cpp,c_glib,php} code. 

Attached is a patch which will wrap our config.h with #ifndef CONFIG_H to guard 
against duplicate definitions and also still allow people who would not have 
config.h to compile properly.  
                
> many compile warning, becase Thread.h includes config.h
> -------------------------------------------------------
>
>                 Key: THRIFT-1824
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1824
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: 2.6.32.43 x86_64 x86_64 x86_64 GNU/Linux
> automake (GNU automake) 1.9.6
> autoconf (GNU Autoconf) 2.59
> autoheader (GNU Autoconf) 2.59
>            Reporter: Jian Yi
>              Labels: patch
>             Fix For: 1.2
>
>         Attachments: Thread.h, Thread.h.diff, THRIFT-1824.patch
>
>
> many compile warning, becase Thread.h includes config.h
> #ifdef HAVE_CONFIG_H
> //#include <config.h> // fix: commented out it
> #endif

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to