[
https://issues.apache.org/jira/browse/THRIFT-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642386#comment-13642386
]
Carl Yeksigian commented on THRIFT-1901:
----------------------------------------
Overall, looks good.
A couple of comments:
# In TMultiplexedProcessor, there is a todo comment in Process. I think that we
should be sending the exception back to the client, instead of throwing the
exception in the server. This is what happens in the case where a function
isn't found, which seems like the type of operation that is happening here.
# The tests need to be updated for sbyte.
> C#: Support for Multiplexing Services on any Transport, Protocol and Server
> ---------------------------------------------------------------------------
>
> Key: THRIFT-1901
> URL: https://issues.apache.org/jira/browse/THRIFT-1901
> Project: Thrift
> Issue Type: Sub-task
> Components: C# - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Fix For: 1.0
>
> Attachments:
> THRIFT-1901_csharp_Support_for_Multiplexing_Services_on_any_Transport_Protocol_and_Server-BYTE-version-v2.patch,
>
> THRIFT-1901_csharp_Support_for_Multiplexing_Services_on_any_Transport_Protocol_and_Server-SBYTE-version-v2.patch
>
>
> See THRIFT-563 for Details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
