[ https://issues.apache.org/jira/browse/THRIFT-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henrique Mendonca closed THRIFT-1957. ------------------------------------- Matthew, I was actually thinking about update the Expresso tests to Mocha, but I guess we can keep nodeunit since it is pretty standard too. We should probably add it to the projects dependencies and also use it for the client/server tests at thrift/tests/nodejs. Cheers, Henrique > NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned > --------------------------------------------------------------------- > > Key: THRIFT-1957 > URL: https://issues.apache.org/jira/browse/THRIFT-1957 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Affects Versions: 0.9 > Environment: NodeJS 10.4, Thrift 0.9 > Reporter: Matthew Imrie > Assignee: Henrique Mendonca > Labels: patch > Fix For: 1.0 > > Attachments: nodejs-thrift-signed-byte-fix.patch > > > Thrift for NodeJS is reading bytes as unsigned. The Apache Thrift > specification describes them as signed. > I changed the readByte function in both TFramedTransport and > TBufferedTransport to call a new readByte method in binary.js that properly > converts to a signed byte. Unit test for the method is included in > binary.test.js -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira