[
https://issues.apache.org/jira/browse/THRIFT-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655590#comment-13655590
]
Carl Yeksigian commented on THRIFT-1953:
----------------------------------------
Overall, looks good. A few more comments:
- Tests have moved from ./test/csharp/ to ./lib/csharp/test
- The C# generator has a warning about an unused variable. Can you please
delete that variable?
- I don't think that we should be building the MVC projects by default. For
example, Mono does not have support for MVC3, so I couldn't compile those
elements.
Overall, looks good though.
> support for asp.net mvc 3
> -------------------------
>
> Key: THRIFT-1953
> URL: https://issues.apache.org/jira/browse/THRIFT-1953
> Project: Thrift
> Issue Type: New Feature
> Components: C# - Compiler, C# - Library
> Affects Versions: 0.9
> Environment: .net framework 4.0 + asp.net mvc 3
> Reporter: xq.gzh
> Priority: Minor
> Fix For: 0.9
>
> Attachments: thrift-0.9.x-asp.net.mvc-support_20130507.patch,
> thrift-XXX-0.9.x-asp.net.mvc3.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> make asp.net mvc 3 can support thrift protocol
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
