[
https://issues.apache.org/jira/browse/THRIFT-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659892#comment-13659892
]
Henrique Mendonca commented on THRIFT-1893:
-------------------------------------------
Hi Phillip, thanks so much for this patch!
It's really a shame that no one has seen this before.
I'd commit your patch but shouldn't we divide the servers and protocol into
different files/folders? e.g.: server/server_tcp.js, server/server_http.js and
protocol/protocol_json.js, protocol/protocol_binary.js
I'm afraid it will get really confusing to have everything together.
For the client we could additionally also use the normal JavaScript test
client, for that we'd only need to be able to serve static files too, like on
"ant -f lib/js/test/build.xml unittest"
What do you think?
> HTTP server/client for node js
> ------------------------------
>
> Key: THRIFT-1893
> URL: https://issues.apache.org/jira/browse/THRIFT-1893
> Project: Thrift
> Issue Type: New Feature
> Components: Node.js - Library
> Reporter: Phillip Campbell
> Priority: Minor
> Labels: node
> Attachments: thrift-1893-node-http.patch
>
>
> I have written a http server for node js, and am in progress on a http client
> for node js. I will contribute a patch file when I am done, however I am
> having a few problems figuring out how things need to be implemented. I am
> trying to follow the ruby implementation as an example, but am unsure how to
> make sure I implement things correct. I assume the link in the README under
> requirements was supposed to explain these things, but currently
> http://wiki.apache.org/thrift/ThriftRequirements leads to gibberish.
> Questions I have are:
> Do I need to implement a JSON protocol?
> On an http request, do I need to ensure the request is a POST? Check for
> headers? What is required?
> Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
