[
https://issues.apache.org/jira/browse/THRIFT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Cline updated THRIFT-1980:
---------------------------------
Description:
This patch improves some of the Go tooling to get it inline with modern
(post-1.0) go development practices.
As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be
built and installed via the go tool. (see http://golang.org/cmd/go/)
It removes the generated Makefiles as they are no longer used for go
development.
Along those lines, the patch also encourages the use of go get to install the
go client library (currently pointing to the github mirror). Not using 'go get'
is non-idiomatic for go development and we should support and encourage
installing via go get.
It also starts including running go tests as part of 'make check'.
was:
This patch removes the generated Makefiles as they are no longer used for go
development.
As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be
built and installed via the go tool. (see http://golang.org/cmd/go/)
Along those lines, the patch also encourages the use of go get to install the
go client library (currently pointing to the github mirror). Not using 'go get'
is non-idiomatic for go development and we should support and encourage
installing via go get.
It also starts including running go tests as part of 'make check'.
> Modernize Go tooling
> --------------------
>
> Key: THRIFT-1980
> URL: https://issues.apache.org/jira/browse/THRIFT-1980
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Affects Versions: 1.0
> Reporter: Travis Cline
> Attachments:
> 0001-THRIFT-1980-Go-Update-autoconf-for-modern-go-direct-.patch
>
>
> This patch improves some of the Go tooling to get it inline with modern
> (post-1.0) go development practices.
> As of go1 (go1.1 is current) 'gomake' et al are missing and Go code should be
> built and installed via the go tool. (see http://golang.org/cmd/go/)
> It removes the generated Makefiles as they are no longer used for go
> development.
> Along those lines, the patch also encourages the use of go get to install the
> go client library (currently pointing to the github mirror). Not using 'go
> get' is non-idiomatic for go development and we should support and encourage
> installing via go get.
> It also starts including running go tests as part of 'make check'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
