[
https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-1977:
--------------------------------
There's another issue. A valid IDL file name is not automatically a valid C#
identifier:
* "my.file.thrift" => error, can't contain dots
* "2bad4you.thrift" => error, must start with letter
* "my file.thrift" => error, cant contain spaces
So the name should be validated to ensure proper C# constant class names.
> C# compiler should generate constant files prefixed with thrift file name
> -------------------------------------------------------------------------
>
> Key: THRIFT-1977
> URL: https://issues.apache.org/jira/browse/THRIFT-1977
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler
> Affects Versions: 0.9, 1.0
> Reporter: Deniss Afonin
> Priority: Minor
> Fix For: 1.0
>
> Attachments: t_csharp_generator.patch, testcases_v2_fixed.zip,
> Testcases.zip,
> THRIFT-1977-Csharp_generate_constant_files_prefixed_with_thrift_file_name-v2.patch,
>
> THRIFT-1977-Csharp_generate_constant_files_prefixed_with_thrift_file_name-v3.patch
>
>
> When you compile (recursively) thrift file that contains constants and
> includes another thrift file with constants, then only one Constants.cs file
> will be produced and it won't contain constants from the included file.
> Compiler should behave like a java version, for each thrift file with
> constants, generate a prefixed constants file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
