[
https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673654#comment-13673654
]
Carl Yeksigian commented on THRIFT-1977:
----------------------------------------
Does it make more sense to put the FileName after "Constants"? That way we can
continue to have the first number as part of the class name. If not, we should
just add the "_" as a prefix, rather than replacing a number.
Otherwise, +1.
> C# compiler should generate constant files prefixed with thrift file name
> -------------------------------------------------------------------------
>
> Key: THRIFT-1977
> URL: https://issues.apache.org/jira/browse/THRIFT-1977
> Project: Thrift
> Issue Type: Improvement
> Components: C# - Compiler
> Affects Versions: 0.9, 1.0
> Reporter: Deniss Afonin
> Fix For: 1.0
>
> Attachments: t_csharp_generator.patch, testcases_v2_fixed.zip,
> Testcases.zip, THRIFT-1977-additional-fix-classnames.patch,
> THRIFT-1977-Csharp_generate_constant_files_prefixed_with_thrift_file_name-v3.patch
>
>
> When you compile (recursively) thrift file that contains constants and
> includes another thrift file with constants, then only one Constants.cs file
> will be produced and it won't contain constants from the included file.
> Compiler should behave like a java version, for each thrift file with
> constants, generate a prefixed constants file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
