[ https://issues.apache.org/jira/browse/THRIFT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675166#comment-13675166 ]
Jens Geyer edited comment on THRIFT-1994 at 6/4/13 8:03 PM: ------------------------------------------------------------ Committed. As an aside: The only two references where slist is really used in the code that I could find are in the Perl and the PHP code, one occurence each. Look for "is_string_list()". was (Author: jensg): Committed. As an aside: The only two references where slist is really used in the code that I could find in the Perl and the PHP code, one occurence each. Look for "is_string_list()". > Deprecate slist > --------------- > > Key: THRIFT-1994 > URL: https://issues.apache.org/jira/browse/THRIFT-1994 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Affects Versions: 1.0 > Environment: All > Reporter: Randy Abernethy > Priority: Minor > Labels: slist > Fix For: 1.0 > > Attachments: > 0001-Added-deprecated-message-to-slist-scanner-patterns.patch > > > I propose the slist type be deprecated (flagged by the compiler as scheduled > for removal) in v1.0 and subsequently removed in a later version of Apache > Thrift. > Rationale: The Apache Thrift IDL type system is compact and elegant with few > exceptions. The slist type is a string in all but PHP/Perl REST targets, > where a string array is generated by splitting the input string on ‘,’. The > slist type offers no cross language utility and is easily replaced in the two > target environments which may require it. This type, and potential type > additions like it, impact a wide range of concerns including language > generators and the effort required to learn Apache Thrift. > The only reference I can find to slist other than the Apache Thrift IDL > syntax page is: > Grokbase 2010/03/13: > --------------------------------------- > [Mayan] What are slist & binary used for? > [Mark Slee] slist is a silly meta-type that's used for the generation of a > REST-style PHP server. It means the data type is a string of comma-separated > primitive values. The generated handler will break apart the string by > exploding on commas before passing to the application. > This is the type of thing that ought to have been an annotation, not a > special type. If we'd had the generic annotation system around at the time > this was written, would have certain used it, but it was a bit of a > quick-hack if I remember correctly. > I'd support deprecating/fixing it now, since having it available as a type > just causes confusion. > --------------------------------------- > Viewed 2013/06/01: > http://grokbase.com/t/thrift/dev/103dxy7tq7/slist-binary > If there is consensus I would be happy to attach a compiler patch producing a > deprecation warning for slist (leaving it otherwise intact). > Best regards, > Randy -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira